wholetrans/docs-matrix-spec
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix knock->leave transition in auth rules (#3694)

Browse source 
* Fix knock->leave transition in auth rules

This was an oversight from knocking being added.

For safety, this has been verified as at least intended by Synapse to work:
f5e2cde3f5/synapse/event_auth.py (L390-L391)

* changelog
This commit is contained in:
Travis Ralston 2022-02-02 08:41:49 -07:00 • committed by GitHub
parent 2cd2a7122c
commit 0f9eadd1a1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
changelogs/room_versions/newsfragments/3694.clarification Normal file
View file

@ -0,0 +1 @@
Fix auth rules to allow membership of `knock` -> `leave` in v7, v8, and v9.

3
content/rooms/fragments/v8-auth-rules.md
View file

@ -91,7 +91,8 @@ The rules are as follows:
5. Otherwise, reject. 5. Otherwise, reject.
5. If `membership` is `leave`: 5. If `membership` is `leave`:
1. If the `sender` matches `state_key`, allow if and only if 1. If the `sender` matches `state_key`, allow if and only if
that user's current membership state is `invite` or `join`. that user's current membership state is `invite`, `join`,
or `knock`.
2. If the `sender`'s current membership state is not `join`, 2. If the `sender`'s current membership state is not `join`,
reject. reject.
3. If the *target user*'s current membership state is `ban`, 3. If the *target user*'s current membership state is `ban`,

3
content/rooms/v7.md
View file

@ -114,7 +114,8 @@ The rules are as follows:
5. Otherwise, reject. 5. Otherwise, reject.
4. If `membership` is `leave`: 4. If `membership` is `leave`:
1. If the `sender` matches `state_key`, allow if and only if 1. If the `sender` matches `state_key`, allow if and only if
that user's current membership state is `invite` or `join`. that user's current membership state is `invite`, `join`,
or `knock`.
2. If the `sender`'s current membership state is not `join`, 2. If the `sender`'s current membership state is not `join`,
reject. reject.
3. If the *target user*'s current membership state is `ban`, 3. If the *target user*'s current membership state is `ban`,