From 125614f3a4a98aac520ba773fa2ec58e10dbc704 Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Date: Thu, 16 Jul 2020 17:26:34 +0100
Subject: [PATCH] Make use of `highlight` tweak consistent (#2670)

* remove redundant 'highlight: false' tweaks

their inconsistent usage is super-confusing.

* Remove redundant 'value: true' on highlight tweaks

again, the inconsistency was super-confusing.

* changelog
---
 .../newsfragments/2670.clarification          |  1 +
 specification/modules/push.rst                | 34 +++----------------
 2 files changed, 5 insertions(+), 30 deletions(-)
 create mode 100644 changelogs/client_server/newsfragments/2670.clarification

diff --git a/changelogs/client_server/newsfragments/2670.clarification b/changelogs/client_server/newsfragments/2670.clarification
new file mode 100644
index 00000000..64d9f142
--- /dev/null
+++ b/changelogs/client_server/newsfragments/2670.clarification
@@ -0,0 +1 @@
+Minor clarifications to the "Push Notifications" module.
diff --git a/specification/modules/push.rst b/specification/modules/push.rst
index 37b149bc..ec855e6b 100644
--- a/specification/modules/push.rst
+++ b/specification/modules/push.rst
@@ -354,10 +354,6 @@ Definition:
             {
                 "set_tweak": "sound",
                 "value": "default"
-            },
-            {
-                "set_tweak": "highlight",
-                "value": false
             }
         ]
     }
@@ -448,8 +444,7 @@ Definition:
         "actions": [
             "notify",
             {
-                "set_tweak": "highlight",
-                "value": true
+                "set_tweak": "highlight"
             }
         ]
     }
@@ -483,8 +478,7 @@ Definition:
         "actions": [
             "notify",
             {
-                "set_tweak": "highlight",
-                "value": true
+                "set_tweak": "highlight"
             }
         ]
     }
@@ -546,10 +540,6 @@ Definition:
             {
                 "set_tweak": "sound",
                 "value": "ring"
-            },
-            {
-                "set_tweak": "highlight",
-                "value": false
             }
         ]
     }
@@ -586,10 +576,6 @@ Definition:
             {
                 "set_tweak": "sound",
                 "value": "default"
-            },
-            {
-                "set_tweak": "highlight",
-                "value": false
             }
         ]
     }
@@ -622,10 +608,6 @@ Definition:
             {
                 "set_tweak": "sound",
                 "value": "default"
-            },
-            {
-                "set_tweak": "highlight",
-                "value": false
             }
         ]
     }
@@ -650,11 +632,7 @@ Definition:
             }
         ],
         "actions": [
-            "notify",
-            {
-                "set_tweak": "highlight",
-                "value": false
-            }
+            "notify"
         ]
    }
 
@@ -681,11 +659,7 @@ Definition:
             }
         ],
         "actions": [
-            "notify",
-            {
-                "set_tweak": "highlight",
-                "value": false
-            }
+            "notify"
         ]
    }