wholetrans/docs-matrix-spec
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix changed-in partial when used with multiple paragraphs (#2006)

Browse source 
When used with a text that includes multiple paragraphs, the partial created invalid HTML by nesting `<p>` elements.
It also changed the rendering by making "Changed in vX.XX:" a separate paragraph, when it is inline with a single paragraph.

To change that we do as with "Required" and add "Changed in vX.XX:" to the text before it is rendered, making it inline with the first paragraph.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This commit is contained in:
Kévin Commaille 2024-11-26 18:53:52 +01:00 • committed by GitHub
parent f3130f70e6
commit c5eac010be
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
changelogs/internal/newsfragments/2006.clarification Normal file
View file

@ -0,0 +1 @@
Fix `changed-in` partial when used with multiple paragraphs.

12
layouts/partials/changed-in.html
View file

@ -1,15 +1,11 @@
{{/*
{{- /*
Renders the "Changed in [version]:" blocks for x-changedInMatrixVersion
annotations for openapi parameters
Takes a single 'changes_dict' parameter, which should be a map of
version -> details pairs.
*/ -}}
{{ range $ver, $details := .changes_dict -}}
<p>
<strong>
Changed in <code>v{{ $ver }}</code>:
</strong>
{{ $details | markdownify }}
</p>
{{- range $ver, $details := .changes_dict -}}
{{- $details = printf "**Changed in `v%s`:** %s" $ver (default "" $details) -}}
{{- $details | page.RenderString (dict "display" "block") -}}
{{ end -}}