wholetrans/docs-matrix-spec
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #44 from matrix-org/speculator-errs

Browse source 
speculator: Don't ignore errors
This commit is contained in:
Kegsay 2015-09-11 15:30:15 +01:00
commit e4f4670260
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
scripts/speculator/main.go
View file

@ -67,13 +67,18 @@ func gitCheckout(path, sha string) error {
return nil
}
func lookupPullRequest(prNumber string) (PullRequest, error) {
resp, _ := http.Get("https://api.github.com/repos/matrix-org/matrix-doc/pulls/" + prNumber)
func lookupPullRequest(prNumber string) (*PullRequest, error) {
resp, err := http.Get("https://api.github.com/repos/matrix-org/matrix-doc/pulls/" + prNumber)
defer resp.Body.Close()
if err != nil {
return nil, fmt.Errorf("error getting pulls: %v", err)
}
dec := json.NewDecoder(resp.Body)
var pr PullRequest
_ = dec.Decode(&pr)
return pr, nil
if err := dec.Decode(&pr); err != nil {
return nil, fmt.Errorf("error decoding pulls: %v", err)
}
return &pr, nil
}
func generate(dir string) error {