From e70045f4ccbe927e7d7ee2e20160bec6ae6d0d39 Mon Sep 17 00:00:00 2001 From: Nicolas Werner <89468146+nico-famedly@users.noreply.github.com> Date: Tue, 7 Jun 2022 23:27:53 +0000 Subject: [PATCH] room_type is not a required parameter in practice (#1110) * room_type is not a required parameter in practice In practice servers seem to mirror what the room create event does and leave out the room_type when unset. Signed-off-by: Nicolas Werner * Add changelog Signed-off-by: Nicolas Werner * Also make room_type and allowed_room_ids optional in the openapi They are optional according to the text, but the openapi marks them as required instead. Signed-off-by: Nicolas Werner * Fix copy and paste error of newsfragment Signed-off-by: Nicolas Werner --- changelogs/client_server/newsfragments/1110.clarification | 1 + changelogs/server_server/newsfragments/1110.clarification | 1 + data/api/client-server/space_hierarchy.yaml | 2 +- data/api/server-server/space_hierarchy.yaml | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 changelogs/client_server/newsfragments/1110.clarification create mode 100644 changelogs/server_server/newsfragments/1110.clarification diff --git a/changelogs/client_server/newsfragments/1110.clarification b/changelogs/client_server/newsfragments/1110.clarification new file mode 100644 index 00000000..3ccb2333 --- /dev/null +++ b/changelogs/client_server/newsfragments/1110.clarification @@ -0,0 +1 @@ +Fix various typos throughout the specification. diff --git a/changelogs/server_server/newsfragments/1110.clarification b/changelogs/server_server/newsfragments/1110.clarification new file mode 100644 index 00000000..3ccb2333 --- /dev/null +++ b/changelogs/server_server/newsfragments/1110.clarification @@ -0,0 +1 @@ +Fix various typos throughout the specification. diff --git a/data/api/client-server/space_hierarchy.yaml b/data/api/client-server/space_hierarchy.yaml index 12640b53..309b99e3 100644 --- a/data/api/client-server/space_hierarchy.yaml +++ b/data/api/client-server/space_hierarchy.yaml @@ -149,7 +149,7 @@ paths: format: int64 description: The `origin_server_ts` for the event. required: [origin_server_ts] - required: [room_type, children_state] + required: [children_state] next_batch: type: string description: |- diff --git a/data/api/server-server/space_hierarchy.yaml b/data/api/server-server/space_hierarchy.yaml index cb30fa0f..834848c9 100644 --- a/data/api/server-server/space_hierarchy.yaml +++ b/data/api/server-server/space_hierarchy.yaml @@ -158,7 +158,7 @@ paths: format: int64 description: The `origin_server_ts` for the event. required: [origin_server_ts] - required: [room_type, allowed_room_ids, children_state] + required: [children_state] children: type: array description: |-