Commit graph

1266 commits

Author SHA1 Message Date
Quentin Gliech
84ccbeacca MSC2918: Refresh tokens (#2918)
* Refresh tokens MSC

* MSC2918: minor changes

* MSC2918: access token expiration as milliseconds

* MSC2918: account registration API changes

* MSC2918: fix `expires_in_ms` example

* MSC2918: add precision about token revocation

* MSC2918: specify error codes for the refresh API

* MSC2918: clarify that the change also applies to ASes

* Apply suggestions from code review

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* MSC2918: clarify what problem this MSC solves

* MSC2918: minor formatting and rephrasing

* MSC2918: clarify ratelimiting, masquerading and authentication on refresh token API

* MSC2918: make expires_in_ms/refresh_token optional

* MSC2918: soft logout in refresh token API

* MSC2918: add detailed rationale

While not exhaustive, it outlines a few attack vectors this MSC tries to
mitigate.

* MSC2918: minor fix

Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>

* MSC2918: clarifications on backward compatibility

* MSC2918: advertise support in the request body

* MSC2918: clarify on what happen when token expire

* MSC2918: remove redundant precision about token expiration and lifetime

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* MSC2918: minor clarification

* MSC2918: soft logout when using expired token

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
2021-09-28 11:14:22 -06:00
Callum Brown
0c3b488805 MSC3231: Token authenticated registration (#3231)
* Proposal for token authenticated registration

Signed-off-by: Callum Brown <callum@calcuode.com>

* Hard-wrap lines

Signed-off-by: Callum Brown <callum@calcuode.com>

* Link to released version of spec

Signed-off-by: Callum Brown <callum@calcuode.com>

* Fix unstable prefix wording

Signed-off-by: Callum Brown <callum@calcuode.com>

* Tokens should only be invalidated after registration

Signed-off-by: Callum Brown <callum@calcuode.com>

* Change auth type to m.login.registration_token

This is consistent with the other UIAA auth types, and does not suggest
that other `m.login.*` types cannot be used for registration.

Signed-off-by: Callum Brown <callum@calcuode.com>

* Add proposal for checking the validity of a token

Signed-off-by: Callum Brown <callum@calcuode.com>

* Fix validity checking endpoint

Signed-off-by: Callum Brown <callum@calcuode.com>

* Limit allowed characters and length of token

This allows tokens to be used easily in query parameters

Signed-off-by: Callum Brown <callum@calcuode.com>

* Give reason for limiting token length and chars

Signed-off-by: Callum Brown <callum@calcuode.com>

* Note all stages must be complete for registration

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* Fix mistake in MSC number

Signed-off-by: Callum Brown <callum@calcuode.com>

* Validity checking should be rate limited

Signed-off-by: Callum Brown <callum@calcuode.com>

* Change v1 to r0

Signed-off-by: Callum Brown <callum@calcuode.com>

* Include `.` and `~` in allowed characters for registration tokens

For consistency with the unreserved URL characters in RFC3986

https://www.ietf.org/rfc/rfc3986.html#section-2.3

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2021-09-27 13:28:11 -06:00
Patrick Cloke
fa479afa97
MSC3375: Room version 9. (#3375)
* Room version 9.

* Fix text which was swapped.

* Update stability.
2021-09-03 08:14:58 -06:00
Sorunome
d9dd37de0c MSC2582: Remove mimetype from EncryptedFile object (#2582)
* add proposal

* Update proposals/2582-remove-mimetype-from-encrypted-file.md

Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>

* Update proposals/2582-remove-mimetype-from-encrypted-file.md

Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>

Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
2021-08-30 08:31:48 -06:00
Alexandre Franke
72888c9a89 Revert per room spell check language MSC
This reverts commit 70192e8e1143ea3450db001b78b05039a3ef58b1.
This reverts commit 1b8f4e22b61196ce37dee0b230ae2c173aaa6676.
2021-08-30 08:31:40 -06:00
Alexandre Franke
c7c3a76c42 Fix MSC number 2021-08-30 08:31:32 -06:00
Alexandre Franke
3eb383c120 Add per room spell check language MSC 2021-08-30 08:31:16 -06:00
Travis Ralston
8b1e4d6a79 Merge pull request #3289 from matrix-org/clokep/room-v8
MSC3289: Room version 8
2021-08-27 19:17:17 +01:00
Patrick Cloke
268cc65198 Revert "Update redaction rules."
This reverts commit 203c107e9e689b7b7812846f78f4712b9ca22539.
2021-08-27 19:17:17 +01:00
Patrick Cloke
0b60680d33 Update redaction rules. 2021-08-27 19:17:17 +01:00
Matthew Hodgson
377aac16fa Update 3289-rooms-v8.md 2021-08-27 19:17:17 +01:00
Patrick Cloke
e229706ae4 Add note about redacting the allow key. 2021-08-27 19:17:17 +01:00
Patrick Cloke
c4d2f94ef8 Add proposal for room version 8. 2021-08-27 19:17:17 +01:00
Travis Ralston
b84d11911f Merge pull request #3083 from matrix-org/clokep/restricted-rooms
MSC3083: Restricting room membership based on membership in other rooms
2021-08-27 19:17:17 +01:00
Patrick Cloke
7ff569f252 Note unstable prefix. 2021-08-27 19:17:17 +01:00
Patrick Cloke
dcd6de59cd De-indent section. 2021-08-27 19:17:17 +01:00
Patrick Cloke
fd0c909644 Clarifications.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2021-08-27 19:17:17 +01:00
Patrick Cloke
7cecb84afe Rename MSC. 2021-08-27 19:17:17 +01:00
Patrick Cloke
c79d1ac350 Clarify error conditions.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
2021-08-27 19:17:17 +01:00
Patrick Cloke
d399653cab Fix typos.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
2021-08-27 19:17:17 +01:00
Patrick Cloke
72961e6f29 More review comments. 2021-08-27 19:17:17 +01:00
Patrick Cloke
977146baf5 Include an additional error situation. 2021-08-27 19:17:17 +01:00
Patrick Cloke
58ccb86a34 Move changes to make/send_join out of auth rules section. 2021-08-27 19:17:17 +01:00
Patrick Cloke
c6f0119b13 Move back section about errors for make/send_join & some review comments. 2021-08-27 19:17:17 +01:00
Patrick Cloke
67e558da52 Review feedback. 2021-08-27 19:17:17 +01:00
Patrick Cloke
27bee1bad8 Apply suggestions from code review
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2021-08-27 19:17:17 +01:00
Patrick Cloke
d329c216c4 Clarify if a resident server cannot issue a join vs. if they're unsure if the user is allowed to join. 2021-08-27 19:17:17 +01:00
Patrick Cloke
6b6aa2449a Add information about errors over federation. 2021-08-27 19:17:17 +01:00
Patrick Cloke
cff5a8728e Add a note about resident servers. 2021-08-27 19:17:17 +01:00
Patrick Cloke
2bc4e86cb4 Updates from review. 2021-08-27 19:17:17 +01:00
Patrick Cloke
248cb8b310 Update the information on signature checking. 2021-08-27 19:17:17 +01:00
Patrick Cloke
72f564c236 Add note about including the authorising server in the content. 2021-08-27 19:17:17 +01:00
Patrick Cloke
c42e89a4d4 Reflow. 2021-08-27 19:17:17 +01:00
Patrick Cloke
04c88f584c Clarify users must be joined to an allowed room.
Co-authored-by: Matthew Hodgson <matthew@matrix.org>
2021-08-27 19:17:17 +01:00
Patrick Cloke
12a39f66df Reword intro. 2021-08-27 19:17:17 +01:00
Patrick Cloke
aed1e23131 Add domains to the example room aliases. 2021-08-27 19:17:17 +01:00
Patrick Cloke
e93accf198 Remove extraneous paragraph. 2021-08-27 19:17:17 +01:00
Patrick Cloke
7aeca9ccb6 Fix typo.
Co-authored-by: Matthew Hodgson <matthew@matrix.org>
2021-08-27 19:17:17 +01:00
Patrick Cloke
1f7481bfbd Fix typo.
Co-authored-by: Travis Ralston <travisr@matrix.org>
2021-08-27 19:17:17 +01:00
Patrick Cloke
48674a3353 Fix typo.
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
2021-08-27 19:17:17 +01:00
Patrick Cloke
84178b1d39 Add notes about the via key and authorised servers being out of sync. 2021-08-27 19:17:17 +01:00
Patrick Cloke
75fc073bfc Clarify implications of signing events. 2021-08-27 19:17:17 +01:00
Patrick Cloke
750be83313 Clarify what happens if a homeserver cannot verify membership. 2021-08-27 19:17:17 +01:00
Patrick Cloke
2749a95251 Use a different room version to specify changes in join rules. 2021-08-27 19:17:17 +01:00
Patrick Cloke
289c64035f Pull note about ban & ACLs out of each join rule description. 2021-08-27 19:17:17 +01:00
Patrick Cloke
ba63bedec0 Clarify that signature checks only apply to joining users. 2021-08-27 19:17:17 +01:00
Patrick Cloke
2171d175e8 Clarify soft-failure is extension of current algorithm.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2021-08-27 19:17:17 +01:00
Patrick Cloke
3377d55c28 Fix typos.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2021-08-27 19:17:17 +01:00
Patrick Cloke
f4e2d925e3 Clarifications / simplifications. 2021-08-27 19:17:17 +01:00
Patrick Cloke
53bae34457 Remove the authorised servers list. 2021-08-27 19:17:17 +01:00